PMM-12912 Add indicator for updates #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| export const UpdatesService = { | ||
| getCurrentVersion: (body: CheckUpdatesBody = { force: false }) => | ||
| api.post<CheckUpdatesResponse, CheckUpdatesBody>('/v1/Updates/Check', body, true), |
There was a problem hiding this comment.
this will impact the "API breaking changes" , https://github.com/percona/pmm/blob/PMM-12913-migrate-api-endpoints-to-restful/api/MIGRATION_TO_V3.md?plain=1
POST /v1/updates/Check was replaced by GET /v1/server/updates
Depending on what branch will be merged first, we need to make changes. To keep that in mind.
doracretu3pillar
approved these changes
Jun 19, 2024
matejkubinec
added a commit
that referenced
this pull request
Jul 23, 2024
* PMM-12912 Add indicator for updates * PMM-12912 Update MegaMenuItem * PMM-12912 Update pmm updates url * PMM-12912 Replace badge with dot * PMM-12912 Show dot based on the update availability * PMM-12912 Adjust dot * PMM-12912 update betterrer * PMM-12912 Fix dot styling * PMM-12912 Reorder comments * PMM-12912 Update api response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds an indicator to the Settings and Updates menu items when an update is available.
Which issue(s) this PR fixes:
PMM-12912
FB: Percona-Lab/pmm-submodules#3602
Screenshots: